Add Pointcloud2 Subscriber #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Haven't look through the code yet but I'm having my doubts whether this belongs here. When developing with ROS, I always try to follow a principle which says that a node should perform a single logical function. In case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Reorganized codebase to isolate subscribers from streamers.
Created image_transport and pointcloud2 subscribers.
Added parameters to control how pointcloud2 msg is converted into an image stream within pointcloud2 subscriber.
Description
This is a big change that will probably take a little back and forth. If you are not interested let me know. The goal was to make it possible to subscribe to ros msg formats other than images and convert them to image streams. Existing msgs subscription capabilities were moved from the existing streamer files to a new image_transport_subscriber file. A new pointcloud2_subscriber option was added that subscribes to pointcloud2 msgs, projects them into a 2d image (user selected viewing frame with parameters for height, width, and focal length), then sends the resulting image to any of the existing streamers.
When coupled with a package like (https://github.com/naoki-mizuno/spacenav_rviz) that moves the selected viewing frame in real time. It is possible to generate a streaming flythrough of a pointcloud with this change.